Skip to content

Avoid large alloc in prometheus metrics with std::map #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ballard26 wants to merge 1 commit into
base: v24.1.x
Choose a base branch
from
Open

Avoid large alloc in prometheus metrics with std::map #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core/prometheus.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ void write_summary(std::stringstream& s, const config& ctx, const sstring& name,
*/
class metric_aggregate_by_labels {
std::vector<std::string> _labels_to_aggregate_by;
std::unordered_map<std::map<sstring, sstring>, seastar::metrics::impl::metric_value> _values;
std::map<std::map<sstring, sstring>, seastar::metrics::impl::metric_value> _values;
public:
metric_aggregate_by_labels(std::vector<std::string> labels) : _labels_to_aggregate_by(std::move(labels)) {
}
Expand All @@ -548,14 +548,14 @@ class metric_aggregate_by_labels {
for (auto&& l : _labels_to_aggregate_by) {
labels.erase(l);
}
std::unordered_map<std::map<sstring, sstring>, seastar::metrics::impl::metric_value>::iterator i = _values.find(labels);
auto i = _values.find(labels);
if ( i == _values.end()) {
_values.emplace(std::move(labels), m);
} else {
i->second += m;
}
}
const std::unordered_map<std::map<sstring, sstring>, seastar::metrics::impl::metric_value>& get_values() const noexcept {
const auto& get_values() const noexcept {
return _values;
}
bool empty() const noexcept {
Expand Down