Fix regression preventing Hud to display more than once#122
Merged
Cheesebaron merged 1 commit intomainfrom Oct 6, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Fix regression so the HUD can be displayed multiple times by preserving the window reference instead of nulling it after dismiss.
- Stop nulling HudWindow in RemoveHud to allow subsequent Show() calls.
- Keep status bar update call intact.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
After fist dismiss HudWindow gets nulled out and does not allow any more huds to be displayed for that Window as a ProgressHud reference is being kept per Window.
Since many phone Apps are single Window, then the ProgressHud will stop working if its internal reference to the HudWindow is nulled out.
This regression was introduced in #117
💥 Does this PR introduce a breaking change?
🐛 Recommendations for testing
Call any Show() method multiple times
📝 Links to relevant issues/docs
#117
Fixes #121
🤔 Checklist before submitting