fix: don't reject asyncErrors #4675
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, any update on this? When this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #GH-4435
This line was causing unhandled promise rejections any time
asyncValidatethrew an error during a submit.We have tested this fork and it made the issue go away, without affecting the errors appearing correctly in our forms.
I also noticed that the tests in
handleSubmit.spec.jsdidn't haveexpect.assertionsstatements, which wasn't a problem for most due to a workaround with throwing insidethen.However, this is still a brittle mechanism, so I added
expect.assertionsto make it more robust. I'm happy to remove that if it shouldn't be in the scope of the PR.