Conversation
Owner
|
WOOT!!! Will review |
reez
reviewed
Feb 24, 2026
reez
reviewed
Feb 24, 2026
reez
reviewed
Feb 24, 2026
reez
reviewed
Feb 24, 2026
reez
reviewed
Feb 24, 2026
Owner
|
Deep review done. First off: this is a huge feature and cool that you made successful sends. The happy path is clearly working. I left comments on a few things Would like to fix before merge (but open to merging even without):
Follow-up OK (non-blocking):
But im totally flexible on how we do this, I can make the changes myself on this pr, or do the follow ups myself? Feel free to let me know what you think makes things easiest. The goal is to get this merged soon and not hold you up or do multiple rounds of reviews that slow this down, and make it an easy process. |
Contributor
Author
|
Thanks for the review, @reez ! I just pushed a new commit fixing these issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds support for broadcasting transactions using the active unsealed slot.
This PR only adds the broadcast functionality. In the next PR, I plan to propose improvements to the sats spending layout.
Evidence
https://drive.google.com/drive/folders/15WbHl6C8QdMslhFajTsN-V7N_cYlOoGI?usp=share_link