Skip to content

feat: broadcast transaction#95

Merged
reez merged 4 commits intoreez:mainfrom
r1b2ns:feat/send-sats
Feb 25, 2026
Merged

feat: broadcast transaction#95
reez merged 4 commits intoreez:mainfrom
r1b2ns:feat/send-sats

Conversation

@r1b2ns
Copy link
Contributor

@r1b2ns r1b2ns commented Feb 22, 2026

It adds support for broadcasting transactions using the active unsealed slot.

This PR only adds the broadcast functionality. In the next PR, I plan to propose improvements to the sats spending layout.

Evidence
https://drive.google.com/drive/folders/15WbHl6C8QdMslhFajTsN-V7N_cYlOoGI?usp=share_link

@reez
Copy link
Owner

reez commented Feb 23, 2026

WOOT!!! Will review

@reez
Copy link
Owner

reez commented Feb 24, 2026

Deep review done.

First off: this is a huge feature and cool that you made successful sends. The happy path is clearly working.

I left comments on a few things

Would like to fix before merge (but open to merging even without):

  1. Post success NFC invalidation can overwrite the success state/message after broadcast (.done isn’t treated as a terminal success state in the invalidation handler).
  2. dump(slot:) -> unseal(cvc:) fallback can unseal the wrong slot when sweeping an inactive slot, because unseal(cvc:) is active-slot only.

Follow-up OK (non-blocking):

  1. “Sweep balance” button state can stay disabled in one fallback path (tx fetch fails but balance fetch succeeds).
  2. Slot row label says “Card ID” while copying/displaying the slot address.

But im totally flexible on how we do this, I can make the changes myself on this pr, or do the follow ups myself? Feel free to let me know what you think makes things easiest.

The goal is to get this merged soon and not hold you up or do multiple rounds of reviews that slow this down, and make it an easy process.

@r1b2ns
Copy link
Contributor Author

r1b2ns commented Feb 24, 2026

Thanks for the review, @reez ! I just pushed a new commit fixing these issues.

Copy link
Owner

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f38a859

HUGE thank you @r1b2ns

@reez reez merged commit 0d4c190 into reez:main Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants