feat: Add note list context menu

[the-jwoo]

Summary

• add a right-click context menu for note rows with note, retargeting, file, archive, and delete actions
• wire row-specific note actions from App into NoteList while preserving the existing Changes view discard/restore menu
• add regression coverage for visible menu actions, row-specific callbacks, and stateful labels

Tests

• pnpm test src/components/NoteList.context-menu.test.tsx

[codacy-production]

Not up to standards ⛔

🔴 Issues 6 high · 44 medium

Alerts:
⚠ 50 issues (≤ 0 issues of at least minor severity)

Results:
50 new issues

Category	Results
UnusedCode	26 medium
BestPractice	7 medium 3 high
ErrorProne	11 medium 3 high

View in Codacy

🟢 Metrics 1126 complexity · 11 duplication

Metric	Results
Complexity	1126
Duplication	11

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

[codacy-production]

Pull Request Overview

While this PR aims to add a necessary context menu to the note list, it currently falls short of quality and verification standards. Although the overall Codacy analysis is 'up to standards', the metadata reveals 32 new issues in NoteContextMenu.tsx and extreme complexity scores in App.tsx (717) and useNoteListModel.tsx (307). Furthermore, none of the required acceptance criteria for the context menu (triggering, action invocation, or stateful labels) have been verified with tests. These quality and coverage gaps should be addressed before merging.

About this PR

• There is a total lack of regression and functional coverage for the new context menu. All 5 identified test scenarios (right-click trigger, action visibility, callback invocation, etc.) are missing from the implementation.
• The PR introduces significant technical debt: NoteContextMenu.tsx contains 32 new issues, and App.tsx has reached an extremely high complexity score of 717. These files should be refactored to ensure maintainability.

Test suggestions

• Context menu triggers on right-click of a note row
• Menu displays all required actions (note, retargeting, file, archive, delete)
• Changes view still displays discard/restore menu correctly
• Clicking a menu action invokes the correct row-specific callback
• Menu labels update correctly based on state (e.g. Archive vs Unarchive)

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Context menu triggers on right-click of a note row
2. Menu displays all required actions (note, retargeting, file, archive, delete)
3. Changes view still displays discard/restore menu correctly
4. Clicking a menu action invokes the correct row-specific callback
5. Menu labels update correctly based on state (e.g. Archive vs Unarchive)

Low confidence findings

• There appears to be a discrepancy or technical issue where code diffs were not accessible to the review agents; this prevents a granular logic verification of the context menu implementation.

_{TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback}

[codacy-production]

Pull Request Overview

The pull request is currently not up to standards, primarily due to high complexity in core logic and several functional gaps in the context menu implementation.

Key issues that should prevent merging include:

• Missing dismissal logic (Escape key/outside clicks) which was a defined acceptance criterion.
• Lack of viewport collision detection, which will cause the menu to render off-screen in common UI positions.
• Significant architectural debt in useNoteListModel.tsx, which has reached a complexity score that threatens maintainability.
• Several features (Changes view prioritization and specific disabling logic for retargeting/markdown files) lack verification and appear unaddressed in the current implementation.

About this PR

• The implementation logic for the Changes view menu in 'useNoteListModel.tsx' may result in the loss of standard note actions while in that view. Please verify if this exclusion is intentional or if the new note actions should be merged with the specialized 'Discard/Restore' logic.
• The new context menu implementation lacks standard accessibility markers. Ensure all new UI elements follow W3C WAI-ARIA patterns for menus to support assistive technologies.

1 comment outside of the diff

src/components/note-list/useNoteListModel.tsx

_{line 575 🔴 HIGH RISK}
The useNoteListModel hook has reached critical complexity (delta 307) and takes 42 parameters. Consider refactoring by grouping related dependencies into NoteListState and NoteListActions objects, and extracting the context menu logic into a separate hook.

Test suggestions

• Context menu opens on right-click and displays all expected primary actions
• Menu items trigger their respective callbacks with the correct entry or path
• Labels update dynamically based on the note's state (e.g., favorite, archived)
• Menu dismisses automatically on Escape key press or clicking outside
• The Changes view prioritizes the specialized changes menu over the generic note menu
• The 'Open in Default App' action is correctly disabled for markdown files
• Retargeting actions are disabled when the entry cannot be moved or changed

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Menu dismisses automatically on Escape key press or clicking outside
2. The Changes view prioritizes the specialized changes menu over the generic note menu
3. The 'Open in Default App' action is correctly disabled for markdown files
4. Retargeting actions are disabled when the entry cannot be moved or changed

_{TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback}

[codacy-production]

_{🟡 MEDIUM RISK}

This label is hardcoded, which prevents localization. Use the 'translate' function with an appropriate i18n key.

Suggested change

	onSelect: () => runAndClose(() => actions.onOpenExternalFile?.(entry.path), onClose),
	label: translate(locale, 'command.note.openExternalApp'),

[codacy-production]

_{🟡 MEDIUM RISK}

Suggestion: Use a native

---

element instead of a

with a separator role. This is more accessible and satisfies semantic HTML standards.

Suggested change

	{index > 0 && <div className="my-1 h-px bg-border" role="separator" />}
	{index > 0 && <hr className="my-1 border-t border-border" />}

See Issue in Codacy
See Issue in Codacy

[codacy-production]

_{🟡 MEDIUM RISK}

Suggestion: The menu may appear partially off-screen if opened near the bottom-right corner of the window. Add viewport collision detection logic to adjust the left and top coordinates so the menu remains fully visible.

[codacy-production]

_{⚪ LOW RISK}

The return value of this arrow function is void. Add braces to the function body to clarify that no value is being returned.

Suggested change

	onSelect: () => runAndClose(() => actions.onRevealFile?.(entry.path), onClose),
	onSelect: () => { runAndClose(() => actions.onRevealFile?.(entry.path), onClose); },

See Issue in Codacy