fix: vault watcher reload loop on iCloud .git symlink vaults

[kossoy]

Summary

• Stop the watcher firing on .git -> .git.nosync paths, which was triggering a reloadVault loop on iCloud-backed vaults — the "Reload vault" status badge flickered every ~1s while idle. Resolves the symlink (and gitdir: worktree pointers) at watcher start and rejects any path inside the resolved directory. Also filters .gitstatus.* cache dirs and *.icloud placeholders.
• Fix scripts/run-vitest-coverage.mjs for standalone pnpm installs: it was passing the pnpm Mach-O / ELF binary to process.execPath (node) and crashing the pre-push hook with SyntaxError: Invalid or unexpected token. Now only takes that fast path when npm_execpath actually looks like a JS module.

Repro for the watcher fix

iCloud / Dropbox Obsidian vaults commonly use the .git -> .git.nosync trick (see vault .gitignore). Background git fetch calls (auto-pull, git_remote_status, gitstatusd) write to the real .git.nosync/ directory, which the existing .git component filter does not match. Each event fired vault-changed → reloadVault, with a 350ms debounce that produced multiple concurrent vault scans per second (visible as Skipped replacing cache because another writer is active warnings in the Rust log).

Test plan

• cargo test --lib vault_watcher — 7 tests, all green (3 new resolver cases + 1 new ignore case + extended temp-file coverage)
• Reproduced loop on real iCloud vault: ~40 cache-skip lines/min before, 0 in 60s after
• pnpm test:coverage — 3378 tests pass with the script fix on a standalone pnpm install

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da8ece8c23

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Filter .gitstatus dirs by component, not basename

The new .gitstatus. ignore rule only inspects path.file_name(), so it ignores events for the directory node itself but still allows events from files inside it. For example, /vault/.gitstatus.ABCD/cache/state has basename state, so is_watchable_path returns true and still emits vault-changed, which can keep the reload churn this patch is trying to eliminate. This should be applied at the path-component level (like the .git check) so nested entries under .gitstatus.* are excluded too.

Useful? React with 👍 / 👎.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 67 complexity · 0 duplication

Metric	Results
Complexity	67
Duplication	0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

[codacy-production]

Pull Request Overview

The PR successfully addresses the vault watcher reload loop issue related to iCloud symlinks and git worktrees. It also improves the compatibility of the Vitest coverage script with native pnpm binaries. While the implementation aligns with the requirements, there is a risk of build failures on Windows due to platform-specific test code. Additionally, the cyclomatic complexity of the file filtering logic has increased beyond recommended thresholds and should be refactored to maintain long-term quality.

About this PR

• Git directory resolution occurs only once during the vault watcher initialization. If a user initializes a new git repository or adds a worktree while the vault is already active, those paths will not be ignored until the application is restarted or the vault is re-opened.

1 comment outside of the diff

src-tauri/src/vault_watcher.rs

_{line 22 🟡 MEDIUM RISK}
This function's cyclomatic complexity (9) exceeds the recommended limit of 8. To improve maintainability, consider refactoring the patterns into a collection (e.g., a static array or HashSet) and using an iterator to check for matches rather than a growing chain of boolean operators.

Test suggestions

• Resolve .git as a symlink to a .nosync directory
• Resolve .git as a worktree pointer using 'gitdir: '
• Filter out file changes occurring within the resolved git directory
• Filter out temporary .gitstatus.* cache files
• Filter out .icloud placeholder files
• Vitest script correctly identifies native pnpm binary vs JS module

_{TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback}

[codacy-production]

_{🟡 MEDIUM RISK}

This test case uses Unix-specific symlink creation (std::os::unix::fs::symlink), which will cause compilation or runtime errors on Windows. To ensure the test suite is cross-platform, wrap this test in a #[cfg(unix)] attribute or use a platform-agnostic crate like symlink for test setup.

[codacy-production]

_{⚪ LOW RISK}

Suggestion: Redundant absolute path check; vault_path.join(target) is sufficient here as well.

[codacy-production]

_{⚪ LOW RISK}

Suggestion: This manual absolute path check is redundant. In Rust, Path::join (and PathBuf::push) automatically handles absolute paths correctly; if the provided argument is absolute, it replaces the previous path entirely.

Suggested change

	if let Ok(target) = std::fs::read_link(&git_path) {
	let resolved = if target.is_absolute() {
	target
	} else {
	vault_path.join(target)
	};
	return Some(resolved);
	}
	if let Ok(target) = std::fs::read_link(&git_path) {
	return Some(vault_path.join(target));
	}