Open
Conversation
bricesanchez
requested changes
Aug 21, 2018
Member
bricesanchez
left a comment
bricesanchez
left a comment
There was a problem hiding this comment.
Thanks @wvk !
This extension really needed to be updated.
Could you read my review and make the changes?
Rakefile
Outdated
| load File.expand_path('../tasks/rspec.rake', __FILE__) | ||
|
|
||
| task :default => :spec No newline at end of file | ||
| task :default => :spec |
Member
There was a problem hiding this comment.
You could use the new syntax
task default: :spec
| present(@page) | ||
| respond_with (@events) do |format| | ||
| format.html | ||
| # format.rss { render layout: false } |
Member
There was a problem hiding this comment.
You should not leave this commented code in the pull request.
Member
There was a problem hiding this comment.
If you are using format.html only, you should keep the previous code with present(@page) and removing respond_to :html
| # you can use meta fields from your model instead (e.g. browser_title) | ||
| # by swapping @page for @event in the line below: | ||
| present(@page) | ||
| respond_with (@event) do |format| |
lib/refinery/calendar.rb
Outdated
| require 'rails_autolink' | ||
| require 'friendly_id' | ||
| require 'jquery-ui-rails' | ||
| require 'globalize' |
Member
There was a problem hiding this comment.
You could safely remove this dependency globalize
| include ActiveSupport::Configurable | ||
|
|
||
| config_accessor :page_url | ||
| # :validate_source_url, :comments_per_page, :posts_per_page, |
Member
There was a problem hiding this comment.
Could you remove all config you don't use ?
Member
|
@wvk I will check the specs after your changes. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just that.