Skip to content

Add LinkedIn links to founder avatars on about page #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alek99 wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −10
Open

Add LinkedIn links to founder avatars on about page #1804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1dca21
Add LinkedIn links to founder avatars on about page
Alek99 Apr 1, 2026
9d162a1
Add rel="noopener noreferrer" to LinkedIn links
Alek99 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions pcweb/pages/about/views/hero.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,27 @@ def hero() -> rx.Component:
),
rx.el.div(
rx.el.div(
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/alek.avif",
alt="Alek",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full pointer-events-none",
rx.el.a(
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/alek.avif",
alt="Alek",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full",
),
href="https://www.linkedin.com/in/aleksanderpetuskey/",
target="_blank",
rel="noopener noreferrer",
),
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/nikhil.avif",
alt="Nikhil",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full pointer-events-none",
rx.el.a(
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/nikhil.avif",
alt="Nikhil",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full",
),
href="https://www.linkedin.com/in/nrao95/",
target="_blank",
Comment on lines +61 to +73
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing rel="noopener noreferrer" on external links

Both target="_blank" links are missing rel="noopener noreferrer". While modern browsers (Chrome 88+, Firefox 79+) now automatically add noopener behavior for target="_blank" links, it's still a best practice to include it explicitly for older browsers and to signal intent clearly. noreferrer additionally prevents the HTTP Referer header from being sent to LinkedIn.

Suggested change
href="https://www.linkedin.com/in/aleksanderpetuskey/",
target="_blank",
),
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/nikhil.avif",
alt="Nikhil",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full pointer-events-none",
rx.el.a(
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/nikhil.avif",
alt="Nikhil",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full",
),
href="https://www.linkedin.com/in/nrao95/",
target="_blank",
rx.el.a(
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/alek.avif",
alt="Alek",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full",
),
href="https://www.linkedin.com/in/aleksanderpetuskey/",
target="_blank",
rel="noopener noreferrer",
),
rx.el.a(
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/nikhil.avif",
alt="Nikhil",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full",
),
href="https://www.linkedin.com/in/nrao95/",
target="_blank",
rel="noopener noreferrer",
),

rel="noopener noreferrer",
),
class_name="flex flex-row items-center -space-x-1",
),
Expand Down
Loading