Allow specification of view range for export #139
Conversation
regcs
left a comment
regcs
left a comment
There was a problem hiding this comment.
Thank you for the contribution! I still need to review this carefully, since it modifies the rendering procedure, which is quite a delicate change. However, I already added two comments you can already address.
__init__.py
Outdated
| "name": "Amber/LG/", | ||
| "author": "Christian Stolze", | ||
| "version": (2, 3, 0), | ||
| "blender": (2, 93, 6), | ||
| "location": "View3D > Looking Glass Tab", | ||
| "description": "Alice/LG takes your artworks through the Looking Glass (light field displays)", | ||
| "description": "Amber/LG is Alice/LG which takes your artworks through the Looking Glass (light field displays) but it doesn't delete files", |
lightfield_render.py
Outdated
| # if ((self.render_settings.addon_settings.render_output == '1' or (not ((self.render_settings.job.animation == False and not self.render_settings.job.file_use_temp) or self.animation == True))) and self.render_settings.job.file_force_keep == False) or self.discard_lockfile == True: | ||
|
|
||
| LookingGlassAddonLogger.info("Cleaning up the disk files.") | ||
| # LookingGlassAddonLogger.info("Cleaning up the disk files.") | ||
|
|
||
| # if it was an animation | ||
| if self.render_settings.job.animation: | ||
| # # if it was an animation | ||
| # if self.render_settings.job.animation: | ||
|
|
||
| # for all frames of the animation | ||
| for frame in range(self.render_settings.job.scene.frame_start, self.render_settings.job.scene.frame_end + self.render_settings.frame_step): | ||
| # # for all frames of the animation | ||
| # for frame in range(self.render_settings.job.scene.frame_start, self.render_settings.job.scene.frame_end + self.render_settings.frame_step): | ||
|
|
||
| # delete views | ||
| self.render_settings.job.delete_files(frame) | ||
| # # delete views | ||
| # self.render_settings.job.delete_files(frame) | ||
|
|
||
| # if it was a still image | ||
| elif not self.render_settings.job.animation: | ||
| # # if it was a still image | ||
| # elif not self.render_settings.job.animation: | ||
|
|
||
| # delete its views | ||
| self.render_settings.job.delete_files() | ||
| # # delete its views | ||
| # self.render_settings.job.delete_files() |
There was a problem hiding this comment.
This must not be commented out. If the user wants to keep the view files in addition to the quilt, they can use the already present UI option.
There was a problem hiding this comment.
Yes, both of these changes are undone in a later commit.
We originally planned to hack together a one time solution so changed the name and hard removed functionality we didn't want.
I have checked these sections of the code directly and they are the same as they were before. Unfortunately, there are a few instances like this, for example, I change all of the 'LookingGlassAddonLogger.info's to print statements because I didn't understand how to get them in the terminal - This has also been undone.
3 participants
Allows the user to specify the range of views they want to render and allows for the rendering of views without the creation of a quilt.
This would allow users to re-render corrupted view(s) and re-compile the quilt externally (solving: #16).
It also eliminates wasted rendering when trying to combine multiple scenes into one quilt - which is my current college project and reason for making the changes.
The view selection piggy backs off of the render farm implementation, making it available to customise in the UI. The UI for this is hidden behind a checkbox bellow 'Add metadata' as to not confuse users.
I have implemented catches and logs in case users enter invalid ranges and have updated the text on certain UI elements to reflect whether the user is rendering a quilt or not ('render quilt' becomes 'start render', if a quilt will not be made).
Please let me know if you need any more information or changes.