feat: APP-578 add data v2 proto files and codegen/build#92
Merged
Conversation
blushi
commented
Mar 20, 2025
| rpc AnchorByIRI(QueryAnchorByIRIRequest) returns (QueryAnchorByIRIResponse) { | ||
| option (google.api.http) = { | ||
| get : "/regen/data/v2/anchor-by-iri/{iri}" | ||
| // additional_bindings : [ {get : "/regen/data/v2/anchors/iri/{iri}"} ] |
Member
Author
There was a problem hiding this comment.
just commenting these additional bindings lines which cause some syntax error when generating typescript code, they are not useful anyway in our case
Member
Author
There was a problem hiding this comment.
I think it doesn't hurt to keep them as comments, because they are in the original proto files from regen-ledger
this reminds us we have to comment them out until this is handled by the ts generation tool
blushi
commented
Mar 20, 2025
| // regen.data.v1 | ||
| '/regen.data.v1.MsgAnchor': { | ||
| // regen.data.v2 | ||
| '/regen.data.v2.MsgAnchor': { |
Member
Author
There was a problem hiding this comment.
main change apart from adding data v2 proto files and codegen
r41ph
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of APP-578