feat: APP-821 stripe account set up from org dashboard#2775
Conversation
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@erikalogie @S4mmyb see testing instructions |
blushi
force-pushed
the
feat-APP-821-org-stripe-account
branch
from
46eb72e to
4846ef7
Compare
did you create the DAO from this PR deploy preview? see my advice for testing on going PRs here:#2772 (comment) |
|
Worked for me! |
|
@codex review |
|
@alexander-astrand could you have a look at this PR when you can? thanks! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4846ef70ac
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
...rketplace/src/legacy-pages/CreateOrganization/hooks/useMigrateProjects/useMigrateProjects.ts
Show resolved
Hide resolved
| grantee | ||
| ) { | ||
| // Ungrant for current account | ||
| const ungrantMsgs = msgTypes.map(typeUrl => |
There was a problem hiding this comment.
Are we sure a grant always exists here? If it doesn’t (never set up or already revoked), could this revoke fail and block the migration?
There was a problem hiding this comment.
if activeAccount?.stripeConnectedAccountId is set up then the grant has to be there, otherwise that would mean the stripe/authz set up is already broken and any credits bought with fiat from the seller would fail to transfer
There was a problem hiding this comment.
Good point, if stripeConnectedAccountId exists, the grants were created during setup. The check is sufficient.
alexander-astrand
left a comment
alexander-astrand
left a comment
There was a problem hiding this comment.
Can't find anything worthy to comment on here, great job!
blushi
force-pushed
the
feat-APP-821-org-stripe-account
branch
from
4846ef7 to
67a2b69
Compare
4 participants
Description
https://regennetwork.atlassian.net/browse/APP-821
needs https://github.com/regen-network/regen-server/pull/558
Also FIXES: setting up authz from org, on org creation when migrating stripe connected account
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
IMPORTANT
You need to create a new DAO from this PR to test this since I had to add authz grant authorization for allowing an org owner/editor to grant authorization to our server account for managing credits/sell orders
Once you have set up this new org, reach out to @blushi so I can allow your organization to use stripe connect so you can see the stripe set up banner
From /dashboard/organization/sell-orders, try to set up a new stripe account.
Once this is done, make sure your org has some credits (you can send some credits from one of your account that has some to your organization dao address) and try to create a fiat sell order.
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...