Conversation
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug preventing the successful migration of on-chain projects to organizations. The core of the fix involves refactoring the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
@erikalogie @S4mmyb see testing instructions |
There was a problem hiding this comment.
Code Review
The pull request refactors the useMigrateProject hook to accept an object as an argument, which includes project, navigateToOrg, and an optional feeGranter. This change improves the flexibility and clarity of the hook's API. The useDaoOrganization hook is now called directly in BasicInfoForm.tsx to provide the feeGranter when needed, centralizing the responsibility for obtaining the organization's address. This refactoring addresses the reported bug related to migrating on-chain projects by correctly passing the feeGranter.
|
LGTM! We should note though that when we support being part of multiple organizations that the user should be able to choose which org it goes to. |
indeed that's a good point. Do we have design for this already @erikalogie ? |
Description
Fixing this bug https://regen-network.slack.com/archives/C07GB7717H6/p1773957974731169 when trying to migrate an on chain project.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...