Skip to content

fix: create project from web2 account#2817

Merged
blushi merged 2 commits intodevfrom
fix-APP-895-project-create-web2
Mar 26, 2026
Merged

fix: create project from web2 account#2817
blushi merged 2 commits intodevfrom
fix-APP-895-project-create-web2

Conversation

@blushi
Copy link
Copy Markdown
Member

@blushi blushi commented Mar 24, 2026

Description

https://regennetwork.atlassian.net/browse/APP-895


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Log in with a web2 account
  2. Click "create project" from the homepage or the user dashboard projects page, it should not show a loading spinner indefinitely

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 24, 2026

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit d49ec14
🔍 Latest deploy log https://app.netlify.com/projects/terrasos/deploys/69c2a4b643d31900081f0b6c
😎 Deploy Preview https://deploy-preview-2817--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug preventing web2 users from successfully initiating project creation due to a perpetually active loading spinner. The fix streamlines the loading state logic within a key data fetching hook, ensuring a more responsive and functional user experience for project setup.

Highlights

  • Bug Fix: Project Creation for Web2 Accounts: Resolved an issue where web2 accounts experienced an indefinite loading spinner when attempting to create a project. This was due to an incorrect dependency in the isLoadingIsIssuer state.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@blushi
Copy link
Copy Markdown
Member Author

blushi commented Mar 24, 2026

@erikalogie @S4mmyb see testing instructions

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug where a loading spinner was displayed indefinitely for web2 accounts attempting to create a project. The root cause was an incorrect loading state calculation in the useQueryIsIssuer hook. The original logic, isFetching || !isFetched, resulted in a persistent loading state for disabled queries, which is the case for users without a wallet address. The fix correctly changes the loading state to depend solely on isFetching, ensuring the loading indicator is only shown when a query is actively in progress. This change is accurate and effectively resolves the issue.

@erikalogie
Copy link
Copy Markdown
Collaborator

LGTM!

@blushi blushi merged commit 4d15710 into dev Mar 26, 2026
14 checks passed
@blushi blushi deleted the fix-APP-895-project-create-web2 branch March 26, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants