Conversation
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug preventing web2 users from successfully initiating project creation due to a perpetually active loading spinner. The fix streamlines the loading state logic within a key data fetching hook, ensuring a more responsive and functional user experience for project setup. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
@erikalogie @S4mmyb see testing instructions |
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where a loading spinner was displayed indefinitely for web2 accounts attempting to create a project. The root cause was an incorrect loading state calculation in the useQueryIsIssuer hook. The original logic, isFetching || !isFetched, resulted in a persistent loading state for disabled queries, which is the case for users without a wallet address. The fix correctly changes the loading state to depend solely on isFetching, ensuring the loading indicator is only shown when a query is actively in progress. This change is accurate and effectively resolves the issue.
|
LGTM! |
Description
https://regennetwork.atlassian.net/browse/APP-895
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...