This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Added Carthage support and updated to iOS 9#45
Open
sales-i-old wants to merge 6 commits intoregexident:masterfrom
Open
Added Carthage support and updated to iOS 9#45sales-i-old wants to merge 6 commits intoregexident:masterfrom
sales-i-old wants to merge 6 commits intoregexident:masterfrom
Conversation
Why: *to able to build using Carthage dependency manager *update any deprecated methods or properties The changes were addressed by: *added a dynamic library and shared to allow Carthage build *DLAlertViewController uses statusbarorientation instead of self *AlertViewTheme imports uikit for proper Carthage build *shared scheme for Carthage
Owner
|
Looks good, thanks! Could you please squash the last four commits (5067039 .. aefe87b) into a single one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
*to able to build using Carthage dependency manager
*update any deprecated methods or properties
The changes were addressed by:
*added a dynamic library and shared to allow Carthage build
*DLAlertViewController uses statusbarorientation instead of self
*AlertViewTheme imports uikit for proper Carthage build
*shared scheme for Carthage