This repository was archived by the owner on Oct 23, 2025. It is now read-only.
Sourcery Starbot ⭐ refactored regonn/polar_bear#8
Open
SourceryAI wants to merge 1 commit intoregonn:masterfrom
Open
Sourcery Starbot ⭐ refactored regonn/polar_bear#8SourceryAI wants to merge 1 commit intoregonn:masterfrom
SourceryAI wants to merge 1 commit intoregonn:masterfrom
Conversation
SourceryAI
commented
Dec 10, 2020
| if dtype in float_dtype_list: | ||
| return 'numerical' | ||
| if (dtype == 'bool') or (dtype == 'object'): | ||
| if dtype in ['bool', 'object']: |
Author
There was a problem hiding this comment.
Function _detect_type refactored with the following changes:
- Replace multiple comparisons of same variable with
inoperator (merge-comparisons)
| droped_values = list(chain.from_iterable( | ||
| pd.Series(row).dropna().str.split(split).to_list())) | ||
| if len(droped_values) == 0: | ||
| if not droped_values: |
Author
There was a problem hiding this comment.
Function convert_multi_category refactored with the following changes:
- Simplify sequence comparison (
simplify-len-comparison)
| series[np.isnan(series)] = mean | ||
| return_df[series.name + "_float"] = series | ||
| elif (dtype == 'object') or (dtype == 'bool'): | ||
| elif dtype in ['object', 'bool']: |
Author
There was a problem hiding this comment.
Function convert_series refactored with the following changes:
- Replace multiple comparisons of same variable with
inoperator (merge-comparisons)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: