Open
Conversation
regosen
reviewed
Aug 25, 2017
|
|
||
| # title: parses the gallery page for a title. This will be the folder name of the output gallery. | ||
| title = r'<title>(.+?)</title>' | ||
| title = r'<title>Porn pics of (.+?) \(Page 1\)</title>' |
Owner
There was a problem hiding this comment.
What if:
a) the user passes a link to a page that isn't Page 1? You could replace the 1 with \d+ which should work for all expected numbers.
b) what if the site changes the format of their titles? Can you change the regex to make the prefix and suffix optional?
Contributor
Author
There was a problem hiding this comment.
a) From my experience it is always (Page 1), whether you are on page 1 or page 8.
b) That's a good idea, at the moment I don't trust my regex skills for such a task. http://www.imagefap.com/forum/viewtopic.php?f=18&t=14892 makes it seem like they haven't updated there layout in awhile and don't plane to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes "Porn pics of" and "(Page 1)" from imagefap gallery titles.