avoid crashing in no assets (api only) mode #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails apps can run in API only mode, which means they do not have an asset pipeline. If one tries to call config.assets for an app like that one gets the following crash: ``` NoMethodError: undefined method 'assets' for an instance of Rails::Application::Configuration (NoMethodError) Did you mean? asset_host my-app/config/environment.rb:7:in '<main>' /bundle:25:in 'Kernel#load' bundle:25:in '<main>' ``` The code a few lines above (95-100) ([ref](https://github.com/0robustus1/rails_semantic_logger/blob/master/lib/rails_semantic_logger/engine.rb#L95-L100)) is already written defensively. This does the same for this invocation of config.assets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Rails apps can run in API only mode, which means they do not have an asset pipeline. If one tries to call config.assets for an app like that one gets the following crash:
The code a few lines above (95-100) (ref) is already written defensively. This does the same for this invocation of config.assets.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.