Skip to content

Main#1

Open
TheSalocin wants to merge 1 commit intoreimerlab:mainfrom
TheSalocin:main
Open

Main#1
TheSalocin wants to merge 1 commit intoreimerlab:mainfrom
TheSalocin:main

Conversation

@TheSalocin
Copy link
Copy Markdown

while collecting upstream_nodes, upstream_edges_neighbors(G,node) returns a list of integers and Nones which leads to an error in indexing. I added a try except clause to return a list of integer values if the elements of the list aren't indexable.

@TheSalocin
Copy link
Copy Markdown
Author

This was just a quickfix I made when running NEURD, and I didn't fully understand the function. Depending on what the expected behaviour is it might be better to return curr_upstream_nodes directly, add a clause to filter out NoneTypes, or add more defensive type checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant