Open
Conversation
Author
|
This was just a quickfix I made when running NEURD, and I didn't fully understand the function. Depending on what the expected behaviour is it might be better to return curr_upstream_nodes directly, add a clause to filter out NoneTypes, or add more defensive type checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while collecting upstream_nodes, upstream_edges_neighbors(G,node) returns a list of integers and Nones which leads to an error in indexing. I added a try except clause to return a list of integer values if the elements of the list aren't indexable.