Skip to content

Update PR description to reflect unified stream.Message envelope implementation#267

Closed
Copilot wants to merge 1 commit intomeling/252/refactor-legacy-send-recv-stream-interfacefrom
copilot/sub-pr-265
Closed

Update PR description to reflect unified stream.Message envelope implementation#267
Copilot wants to merge 1 commit intomeling/252/refactor-legacy-send-recv-stream-interfacefrom
copilot/sub-pr-265

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

The PR description was outdated and referenced the intermediate ordering.Metadata design. The actual implementation uses a unified stream.Message envelope containing both metadata fields and a serialized payload.

Changes

  • Updated architecture description: Documents the unified stream.Message proto containing message_seq_no, method, status, entry, and payload fields
  • Clarified marshaling approach: Application messages are explicitly serialized to/from the payload bytes field using proto registry-based helpers (unmarshalRequest, unmarshalResponse)
  • Documented package rename: orderingstream to better reflect the envelope's purpose
  • Added encoding layer details: Describes the Message wrapper struct and helper functions (NewResponseMessage, AsProto, messageWithError)
  • Specified error handling improvements: Server marshaling failures now send error responses instead of closing the stream

The implementation eliminates the custom codec by leveraging gRPC's type-safe Send/Recv with explicit payload serialization.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@deepsource-io
Copy link
Contributor

deepsource-io bot commented Feb 11, 2026

Here's the code health analysis summary for commits 23f3e46..98619af. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗
DeepSource Shell LogoShell✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copilot AI changed the title [WIP] Refactor legacy SendMsg/RecvMsg to new type-safe Send/Recv interface Update PR description to reflect unified stream.Message envelope implementation Feb 11, 2026
Copilot AI requested a review from meling February 11, 2026 20:53
@meling meling marked this pull request as ready for review February 11, 2026 20:55
@meling
Copy link
Member

meling commented Feb 11, 2026

This is annoying... I didn't ask for a new PR.

@meling meling closed this Feb 11, 2026
@meling meling deleted the copilot/sub-pr-265 branch February 11, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants