This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Split InternalReplicator::replicate into simpler methods#10
Open
jkenn99 wants to merge 3 commits intorelaxedws:8.x-1.xfrom
Open
Split InternalReplicator::replicate into simpler methods#10jkenn99 wants to merge 3 commits intorelaxedws:8.x-1.xfrom
jkenn99 wants to merge 3 commits intorelaxedws:8.x-1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have written my own replicator as a subclass of InternalReplicator but I have a bunch of reused code in the replicate method that should be split into its own methods.
Also, this makes the diff list actually be something other modules can consume for the purpose of showing a workspace diff UI, for example.
In doing this, I also noticed that InternalReplicator::replicate has a side-effect of switching workspaces which this PR fixes.