feat: rust event verifier using native assets#350
Conversation
replacement: ndk
replacement: ndk
|
But it does NOT work on web since it needs flutter, so we're keeping the package |
|
since we now have a web verifier, we might be able to allows either use the native assets rust version or the web, not needing anymore the flutter bridge external package, TBC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #350 +/- ##
==========================================
+ Coverage 75.12% 75.25% +0.12%
==========================================
Files 144 145 +1
Lines 5741 5771 +30
==========================================
+ Hits 4313 4343 +30
Misses 1428 1428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1-leo
left a comment
There was a problem hiding this comment.
Can you add instructions on what to do when modifying the rust code (e.g. run the generator)
We now have /ndk/lib/src/ is this intended, or can we move/organize it somewhere else? How would the process look like if we want to extend functionality?
Are there docs on how to create the pointers and conversions to rust?
I would like to change the rust code to #432 making #432 obsolete.
Comparing performance native assets vs. rust bridge
The For docs on pointers and conversions the best place is probably https://pub.dev/packages/ffi |
Using:
We are now able to use rust event verifier implementation using the new native assets without needing flutter nor a separate package 🎉
fixes #287