Skip to content

feat: rust event verifier using native assets#350

Open
frnandu wants to merge 10 commits intomasterfrom
feat/rust-native-assets
Open

feat: rust event verifier using native assets#350
frnandu wants to merge 10 commits intomasterfrom
feat/rust-native-assets

Conversation

@frnandu
Copy link
Collaborator

@frnandu frnandu commented Dec 22, 2025

Using:

We are now able to use rust event verifier implementation using the new native assets without needing flutter nor a separate package 🎉

fixes #287

@frnandu frnandu requested review from 1-leo and nogringo December 22, 2025 21:22
@frnandu frnandu added this to the 0.7 milestone Dec 22, 2025
@frnandu
Copy link
Collaborator Author

frnandu commented Jan 13, 2026

But it does NOT work on web since it needs flutter, so we're keeping the package ndk_rust_verifier which is to be moved into ndk_flutter package implemented in #244

@relaystr relaystr deleted a comment from codecov bot Jan 13, 2026
@frnandu frnandu self-assigned this Jan 14, 2026
@frnandu frnandu changed the title Feat: rust event verifier using native assets feat: rust event verifier using native assets Jan 15, 2026
@frnandu
Copy link
Collaborator Author

frnandu commented Feb 6, 2026

since we now have a web verifier, we might be able to allows either use the native assets rust version or the web, not needing anymore the flutter bridge external package, TBC

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.25%. Comparing base (4b0e8a5) to head (0f6058d).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
+ Coverage   75.12%   75.25%   +0.12%     
==========================================
  Files         144      145       +1     
  Lines        5741     5771      +30     
==========================================
+ Hits         4313     4343      +30     
  Misses       1428     1428              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nogringo nogringo self-requested a review February 7, 2026 23:33
Copy link
Contributor

@1-leo 1-leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add instructions on what to do when modifying the rust code (e.g. run the generator)

We now have /ndk/lib/src/ is this intended, or can we move/organize it somewhere else? How would the process look like if we want to extend functionality?

Are there docs on how to create the pointers and conversions to rust?

I would like to change the rust code to #432 making #432 obsolete.
Comparing performance native assets vs. rust bridge

@frnandu
Copy link
Collaborator Author

frnandu commented Feb 25, 2026

Can you add instructions on what to do when modifying the rust code (e.g. run the generator)

We now have /ndk/lib/src/ is this intended, or can we move/organize it somewhere else? How would the process look like if we want to extend functionality?

Are there docs on how to create the pointers and conversions to rust?

I would like to change the rust code to #432 making #432 obsolete. Comparing performance native assets vs. rust bridge

The lib/src/rust_lib.dart file is auto-generated by ffigen and follows the native assets convention.
I don't think you need to run anything to generate it, simply modify the rust code and it should just work.

For docs on pointers and conversions the best place is probably https://pub.dev/packages/ffi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rust event verifier without flutter dependency

3 participants