Skip to content

test: add failing tests for slow signer timeout issue #398#399

Open
nogringo wants to merge 8 commits intomasterfrom
fix/issue-398-timeout-during-signing
Open

test: add failing tests for slow signer timeout issue #398#399
nogringo wants to merge 8 commits intomasterfrom
fix/issue-398-timeout-during-signing

Conversation

@nogringo
Copy link
Collaborator

@frnandu
Copy link
Collaborator

frnandu commented Feb 3, 2026

Wouldn't we need 2 timeouts then? Because the app logic might need to also have a time limit for signing, if the signer is unresponsive.

@nogringo
Copy link
Collaborator Author

nogringo commented Feb 4, 2026

Related to #236

@1-leo
Copy link
Contributor

1-leo commented Feb 4, 2026

grafik

For not implement solution 2

tbd: e2e timeout and what to make the default value ajusted by the dev (what to communicate)
e2e || excluding timer signeout (e.g. cache+network)

In cause of signer required after network query its included in the network timeout

@nogringo nogringo force-pushed the fix/issue-398-timeout-during-signing branch from 7cc7fdb to f1817bf Compare February 18, 2026 12:33
@nogringo nogringo self-assigned this Feb 18, 2026
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.62%. Comparing base (881744f) to head (ea76bc4).

Files with missing lines Patch % Lines
...s/ndk/lib/domain_layer/usecases/relay_manager.dart 85.71% 2 Missing ⚠️
...s/ndk/lib/domain_layer/entities/request_state.dart 94.44% 1 Missing ⚠️
...b/domain_layer/usecases/jit_engine/jit_engine.dart 80.00% 1 Missing ⚠️
...k/lib/domain_layer/usecases/relay_sets_engine.dart 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   75.65%   75.62%   -0.03%     
==========================================
  Files         148      148              
  Lines        5886     5924      +38     
==========================================
+ Hits         4453     4480      +27     
- Misses       1433     1444      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nogringo nogringo requested review from 1-leo and frnandu February 19, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants