test: add failing tests for slow signer timeout issue #398#399
Open
test: add failing tests for slow signer timeout issue #398#399
Conversation
Collaborator
|
Wouldn't we need 2 timeouts then? Because the app logic might need to also have a time limit for signing, if the signer is unresponsive. |
Collaborator
Author
|
Related to #236 |
Contributor
7cc7fdb to
f1817bf
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #399 +/- ##
==========================================
- Coverage 75.65% 75.62% -0.03%
==========================================
Files 148 148
Lines 5886 5924 +38
==========================================
+ Hits 4453 4480 +27
- Misses 1433 1444 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#398