unify capitalization of set items and delete no longer used sets#2290
Open
fbenke-pik wants to merge 2 commits intoremindmodel:developfrom
Open
unify capitalization of set items and delete no longer used sets#2290fbenke-pik wants to merge 2 commits intoremindmodel:developfrom
fbenke-pik wants to merge 2 commits intoremindmodel:developfrom
Conversation
fbenke-pik
commented
Feb 27, 2026
| *** | Contact: remind@pik-potsdam.de | ||
| *** SOF ./modules/11_aerosols/exoGAINS2025/sets.gms | ||
| sets | ||
| emisForEmiFac11(all_enty) "types of emissions that are only calculated in a post-processing routine after the optimization" |
Contributor
Author
There was a problem hiding this comment.
This set is used to read in data from f11_emifacs_sectREMIND_sourceCEDS.cs4r and f11_emifacs_sectREMIND_sourceGAINS.cs4r here. The gases were probably capitalized, because of the input data, but it looks like GAMS does not care.
tonnrueter
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The PR solves problems with inconsistent capitalization of set items related to gases and is part of the efforts here
This PR removes some sets
RCP_regions_world_bunkers,RCP_regions_worldandemiRCPthat are no longer used in the code.The set
emisForEmiFac11is adjusted, so that the items SO2, BC and OC are now written lowercase to match the convention for these gases across REMIND.This set is used to read in data from
f11_emifacs_sectREMIND_sourceCEDS.cs4randf11_emifacs_sectREMIND_sourceGAINS.cs4rand the gases were probably capitalized, because of the input data, but it does not seem necessary.Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)