fix(dev): fix setTimeout leaks in default entry.server.tsx
#13416
Conversation
🦋 Changeset detectedLatest commit: 6b1d513 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @remorses, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Add changeset
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
MichaelDeBoey
changed the title
setTimeout leaks in default entry.server.tsxsetTimeout leaks in default entry.server.tsx
| @@ -45,8 +46,10 @@ export default function handleRequest( | |||
| ); | |||
|
|
|||
| pipe(body); | |||
| clearTimeout(timeoutId); | |||
There was a problem hiding this comment.
Clearing here means abort will never be called in streaming scenarios that exceed the time limit since onShellReady fires when the shell is ready but there's still pending stuff to be streamed down, so this is basically clearing the time out at the start of the streamed content, regardless of how long it actually takes.
|
I've merged #14200 in response to the underlying issue. If you are still seeing the same problem please file a new issue. |
If you don't cancel the setTimeout all the closure context is kept in memory until the timeout is called, in this case the whole React tree. This can cause massive memory usage if you are serving many requests