Fix: prendering with basename and ssr:false renders 404s for dynamic routes #13791
Conversation
🦋 Changeset detectedLatest commit: 811fea8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @skrhlm, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
skrhlm
changed the title
the normalized (including basename) was compared with the prerender-entry, which does not have a basename
| if (decodedPathWithoutBasename === "/") { | ||
| decodedPathWithoutBasename = ""; |
There was a problem hiding this comment.
I don't think we needed this check because we just add the trailing slash back on below in !_build.prerender.includes(decodedPath + "/")
| if (strippedPath == null) { | ||
| // 404 on non-pre-rendered `.data` requests | ||
| errorHandler( | ||
| new ErrorResponseImpl( | ||
| 404, | ||
| "Not Found", | ||
| `Refusing to prerender the \`${decodedPath}\` path because it does ` + | ||
| `not start with the basename \`${normalizedBasename}\``, | ||
| ), | ||
| { | ||
| context: loadContext, | ||
| params, | ||
| request, | ||
| }, | ||
| ); | ||
| return new Response("Not Found", { | ||
| status: 404, | ||
| statusText: "Not Found", | ||
| }); | ||
| } |
There was a problem hiding this comment.
If a request comes into the dev server without the basename, we can 404 to match what will happen in production
|
🤖 Hello there, We just published version Thanks! |
|
🤖 bad bot - this is not in 7.8.0 and will be in the next release |
Whenever
basenameandssr: falsewas used together the dynamic urls in the prerender-list (which are without basename) was checked against the normalizedPath, which always has the basename included.This resulted in that any dynamic urls are considered to become 404s in production, which is a false negative.
fixes #12083, #13615