Skip to content

refactor: ConfigPreset type safety and migrate lodash to es-toolkit #14111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

cksal0805
Copy link

@cksal0805 cksal0805 commented Aug 3, 2025

Summary

TL;DR

This PR proposes replacing lodash with es-toolkit across the codebase.

  • Replaced lodash imports in ~48 files with es-toolkit/compat equivalents
  • No functional changes — existing behavior is preserved
  • Removed outdated ESLint rules that caused build warnings

Why this change might help:

  • Smaller bundle size (up to 97% smaller)
  • Improved performance and tree-shaking
  • Modern TypeScript support and compatibility with modern tooling

All tests pass, and core functionality works as expected.
This is a suggestion for consideration — open to feedback or rollback if needed.

https://es-toolkit.dev/compatibility.html

Thanks

Copy link

changeset-bot bot commented Aug 3, 2025

⚠️ No Changeset found

Latest commit: 1929d95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 3, 2025

Hi @cksal0805,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 3, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant