-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Wire up support for unstable_transitions flag #14524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
brophdawg11
wants to merge
20
commits into
dev
Choose a base branch
from
brophdawg11/transitions
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,891
−233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8eefbbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wires up a new
unstable_transitionsflag on the routers that gives you control over the behavior of React transitions in React Router.unstable_transitions={undefined}- Current behavior - Router state updates are wrapped inReact.startTransitionstartTransition(i.e.,startTransition(() => navigate('/'))) because internal mid-navigation state updates aren't surfaced in the current UI (i.e.,useNavigationis stale during the navigation)unstable_transitions={true}- Opt-into additional transition-related behavior inside React RouterReact.startTransition(useNavigate,Link,useSubmit,Form)React.useOptimisticso they can surface to the UI mid-navigationunstable_transitions={false}- Opt-out of all usage ofReact.startTransition/React.useOptimistic<Suspense>,<ViewTransition>,use(), etc.React.useSyncExternalStorewhich is not compatible with transitions (1, 2)RFC: #12855
TODO:
useOptimisticsince it's a react 19 API