Skip to content

Improve AgnosticBaseRouteObject type for projects using exactOptionalPropertyTypes #14585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
+9 −8
Open

Improve AgnosticBaseRouteObject type for projects using exactOptionalPropertyTypes #14585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9d8b8e
Improve AgnosticBaseRouteObject type for projects using exactOptional…
AsamK Nov 23, 2025
344cf49
Sign CLA
AsamK Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
- arnassavickas
- aroyan
- Artur-
- AsamK
- ashusnapx
- avipatel97
- awreese
Expand Down
16 changes: 8 additions & 8 deletions packages/react-router/lib/router/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,14 +628,14 @@ export type LazyRouteDefinition<R extends AgnosticRouteObject> =
* Base RouteObject with common props shared by all types of routes
*/
type AgnosticBaseRouteObject = {
caseSensitive?: boolean;
path?: string;
id?: string;
middleware?: MiddlewareFunction[];
loader?: LoaderFunction | boolean;
action?: ActionFunction | boolean;
hasErrorBoundary?: boolean;
shouldRevalidate?: ShouldRevalidateFunction;
caseSensitive?: boolean | undefined;
path?: string | undefined;
id?: string | undefined;
middleware?: MiddlewareFunction[] | undefined;
loader?: LoaderFunction | boolean | undefined;
action?: ActionFunction | boolean | undefined;
hasErrorBoundary?: boolean | undefined;
shouldRevalidate?: ShouldRevalidateFunction | undefined;
handle?: any;
lazy?: LazyRouteDefinition<AgnosticBaseRouteObject>;
};
Expand Down