Fix issue in typeSelection.ts when handling nullable non-scalars#168
Open
olee wants to merge 1 commit intoremorses:masterfrom
Open
Fix issue in typeSelection.ts when handling nullable non-scalars#168olee wants to merge 1 commit intoremorses:masterfrom
olee wants to merge 1 commit intoremorses:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
Can you add an example here? https://github.com/remorses/genql/blob/master/integration-tests/schema.graphql And a test here if possible https://github.com/remorses/genql/blob/master/integration-tests/tests/execution.ts To run test go inside integration-tests and run |
Author
|
Will see if I can add those soon, thx. |
Owner
|
Even just the graphql schema is enough, I can add tests myself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this library, I notices some strange issues with the output types when relations were not marked as required.
Will try to provide a full example of a schema plus the broken typings the unmodified / modified variants generate later if required.