feat: shader compilation helpers #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidbus
reviewed
Dec 16, 2025
dcvz
force-pushed
the
feat/shader-compilation-helpers
branch
from
58097ff to
4955353
Compare
Contributor
Author
|
@squidbus this is ready again! |
Contributor
Looks okay to me although still have one open comment thread. |
squidbus
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces shader compilation helpers that can be used by projects to make shader compilation easier
based on #78 will rebase once that's merged.
does not take effect until someone pulls in the cmake file like the example does and inits the module -- even then it has the ability to override the DXC or spirv-cross directories which will make us not pull it.