Skip to content

WIP: Extend injector to inject core components into modules#160

Open
tim-kilian wants to merge 2 commits intomasterfrom
core-for-all
Open

WIP: Extend injector to inject core components into modules#160
tim-kilian wants to merge 2 commits intomasterfrom
core-for-all

Conversation

@tim-kilian
Copy link
Copy Markdown
Member

@tim-kilian tim-kilian commented Aug 27, 2019

Closes #156

Describe your changes

  • Use the injector to specify which module component should have access to specific core components

TODO

  • Specify requirements
  • Inject provider
  • Inject behaviors
  • Inject commands
  • Inject rules

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2019

Codecov Report

Merging #160 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   62.93%   63.05%   +0.11%     
==========================================
  Files         154      155       +1     
  Lines        1886     1892       +6     
==========================================
+ Hits         1187     1193       +6     
  Misses        699      699
Impacted Files Coverage Δ
src/features/zoom/providers/ZoomProvider.js 100% <ø> (ø) ⬆️
src/features/remove/providers/RemoveProvider.js 100% <ø> (ø) ⬆️
src/features/connect/providers/ConnectProvider.js 0% <ø> (-20%) ⬇️
src/features/hand/providers/HandProvider.js 100% <ø> (ø) ⬆️
src/features/cursor/providers/CursorProvider.js 100% <ø> (ø) ⬆️
src/features/export/providers/JsonSerializer.js 100% <ø> (ø) ⬆️
src/features/move/providers/MoveProvider.js 100% <ø> (ø) ⬆️
src/features/edit/providers/EditProvider.js 100% <100%> (ø) ⬆️
.../simulation-manager/providers/SimulationManager.js 33.33% <100%> (ø) ⬆️
src/core/Injector.js 95.87% <100%> (+0.22%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc28065...f0eebb5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inject core components in all modules

1 participant