Skip to content

Conversation

@saiintbrisson
Copy link
Collaborator

Introduces a new permission type for controlling wallet stake.

Closes CHAIN-129.

@linear
Copy link

linear bot commented Sep 9, 2025

@coderabbitai
Copy link

coderabbitai bot commented Sep 9, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/permission0/wallet-scope

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@saiintbrisson saiintbrisson merged commit b3696b1 into dev Sep 9, 2025
3 checks passed

pub struct WalletPermission<AccountId> {
pub recipient: AccountId,
pub r#type: WalletScopeType,
Copy link
Collaborator

@steinerkelvin steinerkelvin Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was converted by Polkadot.js to r_type, and in Serde, it would be just type. Even worse, Polkadot.js usually converts the fields to camel case, and in this case, there's this underscore _.

I think it's better for us to avoid using type or other keywords as identifiers if this is going to happen, to avoid inconsistencies in serialization/conversion at interfaces.

Alternatives: kind, variant, body.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed by: #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants