Skip to content

feat(config/options): allow root(.) and UpdateType as parents #36522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Jun 15, 2025

Changes

  • Allow UpdateTypes (major minor, ...) and root ( . ) as parent of config option definition

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Jun 17, 2025

This produces a ~1000 line diff between the main branch JSON schema and this PR. Has it been reviewed for correctness?

@RahulGautamSingh
Copy link
Collaborator Author

This produces a ~1000 line diff between the main branch JSON schema and this PR. Has it been reviewed for correctness?

Yes. enabled will now be added as a children to all npm like manager objects, minor like update type objects so tis is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve config option metadata to define where options can be used and improve JSON schema
4 participants