feat: switch from &str params to String#103
Open
FrenchGithubUser wants to merge 2 commits intoreown-com:masterfrom
Open
feat: switch from &str params to String#103FrenchGithubUser wants to merge 2 commits intoreown-com:masterfrom
&str params to String#103FrenchGithubUser wants to merge 2 commits intoreown-com:masterfrom
Conversation
Author
|
This should be ready for review @geekbrother :) |
Author
|
Bumping this @ganchoradkov @quetool :) |
Author
|
Hey, kindly bumping this @ganchoradkov @quetool :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switched
&strin struct attributes toString. We will be using this library for our push notification gateway Hewdig, and those changes would simplify it use, as well as help future users of a2.Resolves #67
How Has This Been Tested?
cargo testDue Dilligence