Fix the error of duplicate signing within multiple threads#85
Open
henry42 wants to merge 2 commits intoreown-com:masterfrom
Open
Fix the error of duplicate signing within multiple threads#85henry42 wants to merge 2 commits intoreown-com:masterfrom
henry42 wants to merge 2 commits intoreown-com:masterfrom
Conversation
chris13524
previously approved these changes
May 17, 2024
chris13524
approved these changes
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If you use the signer or client in multiple threads, updates to the signature may not be locked and generated too frequently, which can result in Apple rejecting it with '429 The provider token is being updated too frequently.' This pull request fixes the issue, albeit in an ugly but effective way.
How Has This Been Tested?
There is a test function named
test_signature_caching_in_multithreads.Due Dilligence