Open
Conversation
geekbrother
approved these changes
May 20, 2024
geekbrother
left a comment
geekbrother
left a comment
There was a problem hiding this comment.
Thanks! Totally makes sense not closing connections since we are always pushing to it or expecting to push.
| .pool_idle_timeout(pool_idle_timeout_secs.map(Duration::from_secs)) | ||
| .http2_only(true) | ||
| .http2_keep_alive_interval(http2_keep_alive_interval_secs.map(Duration::from_secs)) | ||
| .http2_keep_alive_while_idle(http2_keep_alive_while_idle) |
There was a problem hiding this comment.
Found a panic during testing. Please include the timer:
Suggested change
| .http2_keep_alive_while_idle(http2_keep_alive_while_idle) | |
| .http2_keep_alive_while_idle(http2_keep_alive_while_idle) | |
| .timer(TokioTimer::new()) |
There was a problem hiding this comment.
I tested with this change and the connection resets have stopped. Thanks again for this change
|
just following up if we are merging this in the mainline |
Member
Author
|
@rajesh-blueshift we'll definitely merge this, we've just been super busy with other things. Feel free to use a Git dependency in the meantime, but would love to merge this soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keeps connections open indefinitely, as per recommendation by APNs docs.
Resolves #86
How Has This Been Tested?
Not tested
Due Dilligence