Add WebContent process isolation between contexts#1
Open
seadanda wants to merge 1 commit intoreplghost:mainfrom
Open
Add WebContent process isolation between contexts#1seadanda wants to merge 1 commit intoreplghost:mainfrom
seadanda wants to merge 1 commit intoreplghost:mainfrom
Conversation
Each browsing context (Work, Personal, etc.) now gets a dedicated WKWebsiteDataStore keyed by a stable UUID, ensuring separate WebContent OS processes per context. Prevents cross-context cookie/storage/cache leakage even through renderer exploits. - CSPRNG UUID generation via getrandom (collision-resistant) - Fail-closed: unknown/deleted contexts fall to incognito - macOS 14+ runtime gate (older macOS degrades to incognito) - isolated_tabs takes precedence over named contexts - Migration repairs missing or malformed store_uuid hex strings - 13 new unit tests for UUID generation, parsing, serde, context resolution - All 5 WebView creation paths wired: open_webview, open_webview_background, Open in Context menu, Open Private menu, restore_session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each browsing context (Work, Personal, etc.) now gets a dedicated WKWebsiteDataStore keyed by a stable UUID, ensuring separate WebContent OS processes per context. This prevents cross-context cookie/storage/cache leakage — even through renderer exploits.
What changed
settings.rs — UUID infrastructure + migration
tabs.rs — WebView creation wiring
workbench.rs — Context resolution + all call sites
Security model