Ignore non python files #66
Conversation
daweifeng-replit
requested review from
blast-hardcheese and
jackyzha0
and removed request for
a team
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
packages/pyright-internal/src/common/chokidarFileWatcherProvider.ts
Outdated
Show resolved
Hide resolved
| watcherOptions.usePolling = false; | ||
| } | ||
|
|
||
| const excludes: string[] = ['**/node_modules/**', '**/__pycache__/**', '**/.*', '**/.*/**']; |
There was a problem hiding this comment.
why not just use a negative match pattern? '!**.py'
There was a problem hiding this comment.
Because the whole relative or absolute path is tested, not just filename so when the path is a directory and the path name does not end with .py, it will be ignored
|
|
||
| // Check if any part of the path starts with a dot (hidden file/directory). | ||
| // Exclude '.' and '..' to avoid matching the current/parent directory indicators. | ||
| if (normalizedPath.split('/').some((part) => part.startsWith('.') && part !== '.' && part !== '..')) { |
There was a problem hiding this comment.
this is already the normalized path, there are no . and .. segments
Would you mind take a look at this one? #67 It should make the CI run again |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Why
Previously, the LSP watches all the files within the given paths. We could get
ENOSPC: System limit for number of file watchers reachederror in a large codebase with multiple different programming language files.What changed
ignoreoption of Chokidar is using Anymatch under the hood, which allows us to pass in aAnymatchFnhandler function for customizing our own file matching rules.Test plan
https://replit.com/t/replit/repls/ShouldNotWatchNonPython?replId=dfb12081-2bb1-49b6-8080-5961e0980de9#.replit
In this python repl, we have both the original version pyright-extended running and a version of this PR. And there are 2000 non python files created in the repl. We can see that the original pyright-extended LSP watches 2000 extra files compared to the other one.
