EPMRPP-114193 || Update Open API schema handlers to the version 5.15.1#11
Merged
EPMRPP-114193 || Update Open API schema handlers to the version 5.15.1#11
Conversation
|
Important Review skippedToo many files! This PR contains 206 files, which is 56 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (206)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the generated Go OpenAPI client in pkg/openapi to match ReportPortal API v5.15.1 and bumps the OpenAPI Generator tooling version used for generation.
Changes:
- Bump OpenAPI Generator CLI version used by
Taskfile.yml(to v7.21.0). - Regenerate OpenAPI client for API v5.15.1 (new/changed endpoints, models, and pagination types).
- Refresh generator metadata under
pkg/openapi/.openapi-generator/*and generated README/version banners.
Reviewed changes
Copilot reviewed 204 out of 206 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Taskfile.yml | Updates generator CLI image version used for client regeneration. |
| pkg/openapi/.openapi-generator/VERSION | Records the generator version used for the regenerated client. |
| pkg/openapi/.openapi-generator/FILES | Updates the generator manifest to reflect added/removed generated files. |
| pkg/openapi/README.md | Regenerated client README reflecting API and generator versions plus new endpoints/models. |
| pkg/openapi/client.go | Regenerated client core; includes a small change to multipart file closing logic and updated API version banner. |
| pkg/openapi/configuration.go | Regenerated configuration with updated API version banner. |
| pkg/openapi/response.go | Regenerated response helpers with updated API version banner. |
| pkg/openapi/utils.go | Regenerated utils with updated API version banner (and IsNil used across models). |
| pkg/openapi/api_dashboard.go | Regenerated dashboard APIs; adds PatchDashboard and new locked filtering. |
| pkg/openapi/api_log_async.go | Regenerated async log API request shape for json_request_part. |
| pkg/openapi/api_activity.go | Regenerated activity API request filters ordering/signatures. |
| pkg/openapi/api_user.go | Regenerated user API filters and removes ValidateInfo endpoint. |
| pkg/openapi/api_user_filter.go | Regenerated user filter APIs; adds locked filtering. |
| pkg/openapi/api_widget.go | Regenerated widget APIs; adds locked filtering. |
| pkg/openapi/api_project.go | Regenerated project APIs; reorders filters and updates request builders. |
| pkg/openapi/model_user_resource.go | Regenerated user model; adds loaded, changes metadata typing/serialization behavior. |
| pkg/openapi/model_activity_resource.go | Regenerated activity model; changes details typing/serialization behavior. |
| pkg/openapi/model_activity_event_resource.go | Regenerated activity event model; changes details typing/serialization behavior. |
| pkg/openapi/model_page.go | Regenerated generic Page content typing from []map[string]interface{} to []interface{}. |
| pkg/openapi/model_page_object.go | Regenerated PageObject content typing from []map[string]interface{} to []interface{}. |
| pkg/openapi/model_widget_resource.go | Regenerated widget model; adds locked. |
| pkg/openapi/model_dashboard_resource.go | Regenerated dashboard model; adds locked. |
| pkg/openapi/model_user_filter_resource.go | Regenerated user filter model; adds locked. |
| pkg/openapi/model_owned_entity_resource.go | Regenerated owned entity model; adds locked. |
| pkg/openapi/model_launch_resource.go | Regenerated launch model; adds locked. |
| pkg/openapi/model_launch_resource_old.go | Regenerated legacy launch model; adds locked. |
| pkg/openapi/model_test_item_resource.go | Regenerated test item model; adds hasNestedSteps and analysisOwner. |
| pkg/openapi/model_test_item_resource_old.go | Regenerated legacy test item model; adds hasNestedSteps and analysisOwner. |
| pkg/openapi/model_post_ticket_rq.go | Regenerated ticket request model; adds includeScreenshots and reorders fields/serialization. |
| pkg/openapi/model_save_log_rq.go | Regenerated save-log request model; adds validation regexp for level. |
| pkg/openapi/model_reset_password_rq.go | Regenerated reset-password request model; changes password tag/validation handling. |
| pkg/openapi/model_change_password_rq.go | Regenerated change-password request model; makes newPassword optional per schema. |
| pkg/openapi/model_create_user_rq_full.go | Regenerated create-user model; changes password tag/validation handling. |
| pkg/openapi/model_create_user_rq_confirm.go | Regenerated create-user-confirm model; changes password tag/validation handling. |
| pkg/openapi/model_patch_dashboard_rq.go | New model for PatchDashboard request payload. |
| pkg/openapi/model_bulk_items_rq.go | New model for bulk item ID request payload. |
| pkg/openapi/model_page_paged_log_resource.go | New strongly-typed paged log resource page model. |
| pkg/openapi/model_get_log_types200_response.go | New model for log types listing response envelope. |
| pkg/openapi/model_log_type_request.go | New model for creating/updating project log types. |
| pkg/openapi/model_log_type_response.go | New model for project log type representation. |
| pkg/openapi/model_log_type_style.go | New model for log type styling info. |
| pkg/openapi/model_error.go | New model representing ReportPortal Error schema. |
| pkg/openapi/model_problem.go | Removed model previously generated for RFC9457 “Problem” details. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+423
to
+439
| // GetMetadata returns the Metadata field value if set, zero value otherwise (both if not set or set to explicit null). | ||
| func (o *UserResource) GetMetadata() interface{} { | ||
| if o == nil { | ||
| var ret interface{} | ||
| return ret | ||
| } | ||
| return o.Metadata | ||
| } | ||
|
|
||
| // GetMetadataOk returns a tuple with the Metadata field value if set, nil otherwise | ||
| // and a boolean to check if the value has been set. | ||
| func (o *UserResource) GetMetadataOk() (map[string]interface{}, bool) { | ||
| // NOTE: If the value is an explicit nil, `nil, true` will be returned | ||
| func (o *UserResource) GetMetadataOk() (*interface{}, bool) { | ||
| if o == nil || IsNil(o.Metadata) { | ||
| return map[string]interface{}{}, false | ||
| return nil, false | ||
| } | ||
| return o.Metadata, true | ||
| return &o.Metadata, true |
There was a problem hiding this comment.
GetMetadataOk's docstring says explicit null should return nil, true, but the implementation returns nil, false when Metadata is nil (including when JSON contains "metadata": null). Either remove/adjust the docstring to match the actual behavior, or implement a nullable wrapper/custom unmarshal that can distinguish “field absent” vs “explicit null”.
Comment on lines
+273
to
+289
| // GetDetails returns the Details field value if set, zero value otherwise (both if not set or set to explicit null). | ||
| func (o *ActivityResource) GetDetails() interface{} { | ||
| if o == nil { | ||
| var ret interface{} | ||
| return ret | ||
| } | ||
| return o.Details | ||
| } | ||
|
|
||
| // GetDetailsOk returns a tuple with the Details field value if set, nil otherwise | ||
| // and a boolean to check if the value has been set. | ||
| func (o *ActivityResource) GetDetailsOk() (map[string]interface{}, bool) { | ||
| // NOTE: If the value is an explicit nil, `nil, true` will be returned | ||
| func (o *ActivityResource) GetDetailsOk() (*interface{}, bool) { | ||
| if o == nil || IsNil(o.Details) { | ||
| return map[string]interface{}{}, false | ||
| return nil, false | ||
| } | ||
| return o.Details, true | ||
| return &o.Details, true |
There was a problem hiding this comment.
GetDetailsOk's docstring claims explicit null should return nil, true, but the implementation returns nil, false when Details is nil. Either update the docstring to match the behavior, or introduce a nullable wrapper/custom unmarshal if callers truly need to distinguish “absent” vs “explicit null”.
Comment on lines
+345
to
+361
| // GetDetails returns the Details field value if set, zero value otherwise (both if not set or set to explicit null). | ||
| func (o *ActivityEventResource) GetDetails() interface{} { | ||
| if o == nil { | ||
| var ret interface{} | ||
| return ret | ||
| } | ||
| return o.Details | ||
| } | ||
|
|
||
| // GetDetailsOk returns a tuple with the Details field value if set, nil otherwise | ||
| // and a boolean to check if the value has been set. | ||
| func (o *ActivityEventResource) GetDetailsOk() (map[string]interface{}, bool) { | ||
| // NOTE: If the value is an explicit nil, `nil, true` will be returned | ||
| func (o *ActivityEventResource) GetDetailsOk() (*interface{}, bool) { | ||
| if o == nil || IsNil(o.Details) { | ||
| return map[string]interface{}{}, false | ||
| return nil, false | ||
| } | ||
| return o.Details, true | ||
| return &o.Details, true |
There was a problem hiding this comment.
GetDetailsOk's docstring claims explicit null should return nil, true, but the implementation returns nil, false when Details is nil. Either update the docstring to match the behavior, or introduce a nullable wrapper/custom unmarshal if callers truly need to distinguish “absent” vs “explicit null”.
AleksandrParamonoff
force-pushed
the
update-open-api-schema
branch
from
a596545 to
ec668f9
Compare
AleksandrParamonoff
force-pushed
the
update-open-api-schema
branch
from
ec668f9 to
de02853
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated OpenAPITools/openapi-generator version to v7.21.0