Open
Conversation
Member
Author
|
Oh yeah and we have the RSA tests here now. |
Member
|
Looks good to me 👍 would be good to get Travis up and running here too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #17 I migrated the tests to tape, also added instanbul as a dev dependency. Currently there is no automated build, but still you can easily see the coverage which turned out to be pretty good.
What I didn't noticed the other day was that the oauth-sign test results in request's test-oauth, are used for comparison in the subsequent request tests, so at this point I don't think I'm going to remove the oauth-sign tests from there.
Let me know what do you think.