Skip to content

fix: resolve localhost requests with IP literal URLs #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsrCodes merged 1 commit into from
Feb 16, 2026
Merged

fix: resolve localhost requests with IP literal URLs #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/main/actions/getProxiedAxios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {

const LOCAL_IPV4 = "127.0.0.1";
const LOCAL_IPV6 = "::1";
const LOCAL_UNSPECIFIED = "0.0.0.0";

const checkConnection = (host: string, port: number): Promise<boolean> => {
return new Promise((resolve) => {
Expand Down Expand Up @@ -104,14 +105,28 @@ function createAxiosInstance(
const url = new URL(requestUrl);
const { hostname, port: urlPort, protocol } = url;

if (hostname === "localhost" || hostname === LOCAL_IPV6 || hostname === LOCAL_IPV4) {
// convert string port to integer
const isLocalhost = hostname === "localhost"
|| hostname === LOCAL_IPV4
|| hostname === `[${LOCAL_IPV6}]`
|| hostname === LOCAL_UNSPECIFIED;

if (isLocalhost) {
const port = urlPort ? parseInt(urlPort, 10) : protocol === "https:" ? 443 : 80;

const lookup = await createLocalhostLookup(port);

requestConfig.httpAgent = new http.Agent({ lookup });
requestConfig.httpsAgent = new https.Agent({ lookup });

// Node.js skips DNS lookup for raw IP literals, so the custom lookup
// above has no effect. Rewrite the URL to the concrete working IP.
if (hostname !== "localhost") {
const ipv6Works = await checkConnection(LOCAL_IPV6, port).catch(() => false);
const targetIp = ipv6Works ? `[${LOCAL_IPV6}]` : LOCAL_IPV4;

if (hostname !== targetIp) {
requestConfig.url = requestUrl.replace(hostname, targetIp);
}
}
}

return requestConfig;
Expand Down