Skip to content

Comments

ENGG-5319 : Fix form-urlencoded body handling for GET requests#295

Open
srbh777 wants to merge 1 commit intomasterfrom
ENGG-5319
Open

ENGG-5319 : Fix form-urlencoded body handling for GET requests#295
srbh777 wants to merge 1 commit intomasterfrom
ENGG-5319

Conversation

@srbh777
Copy link

@srbh777 srbh777 commented Feb 19, 2026

Summary

  • Removed GET from the form-urlencoded body processing exclusion list so that GET requests with application/x-www-form-urlencoded content type are properly encoded

Context

The web app now allows GET request bodies in desktop mode. All content types (JSON, raw, multipart) were already handled correctly for GET, but form-urlencoded was explicitly skipped — causing the raw key-value pair array to be sent
instead of properly encoded URLSearchParams.

Changes

  • makeApiClientRequest.js: Changed !["GET", "HEAD"].includes(method) to method !== "HEAD" in the form-urlencoded body processing condition

Test plan

  • Send GET request with application/x-www-form-urlencoded body → server should receive properly encoded form data (e.g. key1=value1&key2=value2)
  • Send GET request with JSON body → should still work as before
  • Send GET request with raw body → should still work as before
  • Send POST/PUT/PATCH with form-urlencoded body → should still work as before
  • HEAD requests should still have no body

@linear
Copy link

linear bot commented Feb 19, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant