Convert a repository url from SSH to HTTPS. #1120
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes broken package repository links by converting Git-specific URL schemes (git+ssh:, git+, git:) to standard HTTPS format, enabling proper navigation from the Packages page.
Key changes:
- Added URL conversion logic to normalize Git repository URLs to HTTPS format
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/Packages.res
Outdated
| // Convert a repository url from SSH to HTTPS. | ||
| let repositoryHref = switch repositoryHref { | ||
| | href if String.startsWith(href, "git+ssh") => { | ||
| String.replace(href, "git+ssh:", "https:") } |
There was a problem hiding this comment.
There is excessive trailing whitespace before the closing brace. This should be removed to maintain consistent formatting.
Copilot uses AI. Check for mistakes.
|
Sorry, the format check in CI was broken (fix here). |
|
Thanks for the review! I've run |
2 participants
This pull request fixes broken repository links on the Packages page.
Currently, links fail when a package's repository is defined with a Git-specific URL scheme (e.g., git+ssh:, git:, git+). This PR introduces logic to convert these schemes into a standard HTTPS format.