Skip to content

fix(tailwind): media-query stripping #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: canary
Choose a base branch
from
Open

fix(tailwind): media-query stripping #2408

wants to merge 4 commits into from

Conversation

PedroMarianoAlmeida
Copy link
Contributor

Solves #2388

Demo:

Screen.Recording.2025-08-03.at.11.47.05.PM.mov

Playground file added:

path: playground/emails/test-media-query-bug.tsx

import { Body, Head, Html, Text, Tailwind } from '@react-email/components';

const TestMediaQueryBug = () => {
  return (
    <Tailwind
      config={{
        darkMode: 'media',
        plugins: [
          ({ addUtilities }: any) => {
            addUtilities({
              '.text-body': {
                '@apply text-[green] dark:text-[orange]': {},
              },
            });
          },
        ],
      }}
    >
      <Html>
        <Head />
        <Body>
          <Text className="text-body">
            This text should be green in light mode and orange in dark mode
          </Text>
          <Text className="text-[green] dark:text-[orange]">
            This text uses inline classes and should work correctly
          </Text>
        </Body>
      </Html>
    </Tailwind>
  );
};

export default TestMediaQueryBug;

I can create tests if necessary!

@PedroMarianoAlmeida PedroMarianoAlmeida requested a review from a team as a code owner August 4, 2025 03:10
@PedroMarianoAlmeida PedroMarianoAlmeida requested review from CarolinaMoraes and removed request for a team August 4, 2025 03:10
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c21b334

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Aug 4, 2025

@PedroMarianoAlmeida is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 4, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/resend/react-email/@react-email/tailwind@2408

commit: c21b334

@PedroMarianoAlmeida PedroMarianoAlmeida force-pushed the fix/media-query-stripping branch from 6518954 to b37d6ee Compare August 4, 2025 03:17
@PedroMarianoAlmeida PedroMarianoAlmeida changed the title fix/media-query-stripping fix(package>taiwind):media-query-stripping Aug 4, 2025
@PedroMarianoAlmeida PedroMarianoAlmeida changed the title fix(package>taiwind):media-query-stripping fix(package-tailwind): media-query stripping Aug 4, 2025
@PedroMarianoAlmeida PedroMarianoAlmeida force-pushed the fix/media-query-stripping branch from b37d6ee to 9eb070e Compare August 4, 2025 03:28
@gabrielmfern gabrielmfern changed the title fix(package-tailwind): media-query stripping fix(tailwind): media-query stripping Aug 4, 2025
@Zdend
Copy link

Zdend commented Aug 11, 2025

I appreciate you tackling this @PedroMarianoAlmeida 🙏

@cpenned @cubic-dev-ai
refactor: remove discord link (resend#2423)
847b1d5 
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@Zdend
Copy link

Zdend commented Aug 28, 2025

@gabrielmfern is there anything I can do to support this PR being merged? 🙏

@gabrielmfern gabrielmfern force-pushed the canary branch 3 times, most recently from 8128be7 to 19de23f Compare October 17, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarolinaMoraes CarolinaMoraes Awaiting requested review from CarolinaMoraes CarolinaMoraes was automatically assigned from resend/engineering

@gabrielmfern gabrielmfern Awaiting requested review from gabrielmfern

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PedroMarianoAlmeida @Zdend @cpenned @gabrielmfern