-
Couldn't load subscription status.
- Fork 839
chore(deps-dev): bump happy-dom from 18.0.1 to 20.0.0 #2560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [happy-dom](https://github.com/capricorn86/happy-dom) from 18.0.1 to 20.0.0. - [Release notes](https://github.com/capricorn86/happy-dom/releases) - [Commits](capricorn86/happy-dom@v18.0.1...v20.0.0) --- updated-dependencies: - dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review the following alerts detected in dependencies. According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="package.json">
<violation number="1" location="package.json:22">
This update to `happy-dom` v20.0.0 introduces a breaking change by disabling JavaScript evaluation by default. Multiple `vitest.config.ts` files across the repository use `happy-dom` as the test environment but have not been updated to re-enable it, which will cause widespread test failures.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| "@types/react": "19.0.1", | ||
| "@types/react-dom": "19.0.1", | ||
| "happy-dom": "18.0.1", | ||
| "happy-dom": "20.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update to happy-dom v20.0.0 introduces a breaking change by disabling JavaScript evaluation by default. Multiple vitest.config.ts files across the repository use happy-dom as the test environment but have not been updated to re-enable it, which will cause widespread test failures.
Prompt for AI agents
Address the following comment on package.json at line 22:
<comment>This update to `happy-dom` v20.0.0 introduces a breaking change by disabling JavaScript evaluation by default. Multiple `vitest.config.ts` files across the repository use `happy-dom` as the test environment but have not been updated to re-enable it, which will cause widespread test failures.</comment>
<file context>
@@ -19,7 +19,7 @@
"@types/react": "19.0.1",
"@types/react-dom": "19.0.1",
- "happy-dom": "18.0.1",
+ "happy-dom": "20.0.0",
"pkg-pr-new": "0.0.54",
"tsconfig": "workspace:*",
</file context>
|
Superseded by #2568. |
Bumps happy-dom from 18.0.1 to 20.0.0.
Release notes
Sourced from happy-dom's releases.
... (truncated)
Commits
819d15bBREAKING CHANGE: #0 Changes JavaScript evaluation to be disabled by default...c80a08ffix: #1620 Fixes issue related to CSS pseudo selector :scope (#1911)220df23fix: #1908 Fixes issue with sending in URLs as string in server-renderer co...9849f8bchore: #1906 Fixes failing unit test caused by package version (#1907)48d174echore: #1904 Updates conventional commit package (#1905)275efe5BREAKING CHANGE: #1620 Release v18.0.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by cubic
Upgrade the dev dependency happy-dom from 18.0.1 to 20.0.0. This brings a security hardening that disables JavaScript evaluation by default, which may affect tests that rely on script execution.