fix(hooks): remove stale refs to retired dev/scripts/git-hooks#58
fix(hooks): remove stale refs to retired dev/scripts/git-hooks#58WomB0ComB0 merged 1 commit intomasterfrom
Conversation
- .github/workflows/hooks-sync.yml: drop `drift-check-dev` job. It fetched from resq-software/dev/main/scripts/git-hooks/ — which was retired in resq-software/dev#6 — so the job would fail every run. The remaining local drift-check between templates/ and .git-hooks/ is now the whole check surface. - AGENTS.md + CLAUDE.md: rewrite the Git hooks section to reflect the post-Phase-4 reality. This repo is the single source of truth; the old "will converge once resq dev install-hooks scaffolds from embedded templates" qualifier is obsolete (shipped in #48). The link to dev/tree/main/scripts/git-hooks no longer resolves; replaced with a forward link to the installer. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 51 minutes and 15 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
C-Documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates AGENTS.md and CLAUDE.md to establish this repository as the source of truth for canonical git-hook templates, detailing their storage location and installation process for sibling repositories. Feedback was provided to correct the branch name from master to main and to fix inconsistent link labels in the documentation.
| Canonical hooks are maintained in [`resq-software/dev`](https://github.com/resq-software/dev/tree/main/scripts/git-hooks) and delegate to `resq pre-commit` from this workspace. This repo's own `.git-hooks/` predates the canonical contract and builds `resq-cli` locally as a bootstrap — it will converge on the canonical shims once `resq dev install-hooks` can scaffold from embedded templates. See [resq-software/dev/AGENTS.md#git-hooks](https://github.com/resq-software/dev/blob/main/AGENTS.md#git-hooks). | ||
| This repo is the **source of truth** for canonical git-hook templates across the ResQ org. They live in [`crates/resq-cli/templates/git-hooks/`](crates/resq-cli/templates/git-hooks) and are embedded into the `resq` binary via `include_str!`, so `resq dev install-hooks` can scaffold them offline into any repo. The `.git-hooks/` copy in this repo's root is kept byte-identical by `hooks-sync.yml` CI. | ||
|
|
||
| Sibling repos install these via [`resq-software/dev/scripts/install-hooks.sh`](https://github.com/resq-software/dev/blob/main/scripts/install-hooks.sh), which prefers the offline `resq dev install-hooks` path when the binary is available and falls back to raw-fetching from this repo's `master` branch. See [resq/AGENTS.md#git-hooks](https://github.com/resq-software/dev/blob/main/AGENTS.md#git-hooks) for the full contract. |
There was a problem hiding this comment.
The branch name master appears to be incorrect, as other references in this PR and the organization (e.g., the dev repository) use main. Additionally, the link label resq/AGENTS.md is inconsistent with the URL which points to the resq-software/dev repository.
| Sibling repos install these via [`resq-software/dev/scripts/install-hooks.sh`](https://github.com/resq-software/dev/blob/main/scripts/install-hooks.sh), which prefers the offline `resq dev install-hooks` path when the binary is available and falls back to raw-fetching from this repo's `master` branch. See [resq/AGENTS.md#git-hooks](https://github.com/resq-software/dev/blob/main/AGENTS.md#git-hooks) for the full contract. | |
| Sibling repos install these via [`resq-software/dev/scripts/install-hooks.sh`](https://github.com/resq-software/dev/blob/main/scripts/install-hooks.sh), which prefers the offline `resq dev install-hooks` path when the binary is available and falls back to raw-fetching from this repo's `main` branch. See [resq-software/dev/AGENTS.md#git-hooks](https://github.com/resq-software/dev/blob/main/AGENTS.md#git-hooks) for the full contract. |
| Canonical hooks are maintained in [`resq-software/dev`](https://github.com/resq-software/dev/tree/main/scripts/git-hooks) and delegate to `resq pre-commit` from this workspace. This repo's own `.git-hooks/` predates the canonical contract and builds `resq-cli` locally as a bootstrap — it will converge on the canonical shims once `resq dev install-hooks` can scaffold from embedded templates. See [resq-software/dev/AGENTS.md#git-hooks](https://github.com/resq-software/dev/blob/main/AGENTS.md#git-hooks). | ||
| This repo is the **source of truth** for canonical git-hook templates across the ResQ org. They live in [`crates/resq-cli/templates/git-hooks/`](crates/resq-cli/templates/git-hooks) and are embedded into the `resq` binary via `include_str!`, so `resq dev install-hooks` can scaffold them offline into any repo. The `.git-hooks/` copy in this repo's root is kept byte-identical by `hooks-sync.yml` CI. | ||
|
|
||
| Sibling repos install these via [`resq-software/dev/scripts/install-hooks.sh`](https://github.com/resq-software/dev/blob/main/scripts/install-hooks.sh), which prefers the offline `resq dev install-hooks` path when the binary is available and falls back to raw-fetching from this repo's `master` branch. See [resq/AGENTS.md#git-hooks](https://github.com/resq-software/dev/blob/main/AGENTS.md#git-hooks) for the full contract. |
There was a problem hiding this comment.
The branch name master appears to be incorrect, as other references in this PR and the organization (e.g., the dev repository) use main. Additionally, the link label resq/AGENTS.md is inconsistent with the URL which points to the resq-software/dev repository.
| Sibling repos install these via [`resq-software/dev/scripts/install-hooks.sh`](https://github.com/resq-software/dev/blob/main/scripts/install-hooks.sh), which prefers the offline `resq dev install-hooks` path when the binary is available and falls back to raw-fetching from this repo's `master` branch. See [resq/AGENTS.md#git-hooks](https://github.com/resq-software/dev/blob/main/AGENTS.md#git-hooks) for the full contract. | |
| Sibling repos install these via [`resq-software/dev/scripts/install-hooks.sh`](https://github.com/resq-software/dev/blob/main/scripts/install-hooks.sh), which prefers the offline `resq dev install-hooks` path when the binary is available and falls back to raw-fetching from this repo's `main` branch. See [resq-software/dev/AGENTS.md#git-hooks](https://github.com/resq-software/dev/blob/main/AGENTS.md#git-hooks) for the full contract. |
1 participant
Summary
Three stale references surfaced by an org-wide audit after the Phase 4 retirement landed in resq-software/dev#6:
.github/workflows/hooks-sync.yml— thedrift-check-devjob still fetched fromresq-software/dev/main/scripts/git-hooks/. That path no longer exists, so the job would fail every run. Removed.AGENTS.md+CLAUDE.md— the Git hooks section pointed at the 404'd dev path and carried the obsolete qualifier "will converge onceresq dev install-hookscan scaffold from embedded templates" (that shipped in feat(resq-cli):hookssubcommand +dev scaffold-local-hook#48). Rewrote to reflect the single-source-of-truth reality: this repo'scrates/resq-cli/templates/git-hooks/is canonical; the dev/ installer fetches from here.Test plan
agent-sync.shkeeps AGENTS.md ↔ CLAUDE.md in synclint+drift-check-local) instead of three; both should be green🤖 Generated with Claude Code