fix(deny): migrate to cargo-deny v2 schema#67
Conversation
cargo-deny v0.14+ removed [licenses].unlicensed and [licenses].deny. Schema now uses [licenses].version = 2 + implicit-denial-by-omission from allow list. See EmbarkStudios/cargo-deny#611.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 32 minutes and 19 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the deny.toml configuration for cargo-deny v2 by removing the explicit license denial list and adding a version field. Feedback suggests restoring the unlicensed = "deny" configuration for clarity and maintainability, as it remains a valid key in the v2 schema.
|
|
||
| [licenses] | ||
| unlicensed = "deny" | ||
| version = 2 |
There was a problem hiding this comment.
The unlicensed key has not been removed in the cargo-deny v2 configuration schema; it remains a valid option within the [licenses] section. While it defaults to "deny" when omitted, keeping it explicit is recommended for maintainability and clarity, particularly as the PR description incorrectly states it was removed. Note that crates lacking license metadata are governed specifically by this key and are not filtered by the allow list of license identifiers.
| version = 2 | |
| version = 2 | |
| unlicensed = "deny" |
1 participant
cargo-deny v2 removed
[licenses].unlicensedand[licenses].deny. Failing every run on master witherror[deprecated]: this key has been removed. Migrate toversion = 2+ implicit denial from the allow-list.🤖 Generated with Claude Code