pickadate-special class and TypeError fix#88
Open
evancarey wants to merge 7 commits intorestorando:masterfrom
Open
pickadate-special class and TypeError fix#88evancarey wants to merge 7 commits intorestorando:masterfrom
evancarey wants to merge 7 commits intorestorando:masterfrom
Conversation
enable highlighting dates via css. Use case: dates for an event, like a conference, can be highlighted via an underline and remain selectable.
This reverts commit a8c224b.
'TypeError: dateString.split is not a function.' error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a requirement to highlight a set of dates with custom css. Using the disabled dates feature as a guide a function can be passed to the directive that can trigger the addition of a pickadate-special class to the dates.
Also, fixed 'TypeError:dateString.split is not a function' errors that can occur when the ngModel.$viewValue is undefined and subsequent calls to parseDate would be made with a previously built date object (instead of a string) taken from selectedDates[0] which in my case would occur if the user refreshed the application and subsequent digest cycles executed before the view model was replenished with data.