Skip to content

Fix HAVE_TE detection across remaining files missing direct transformer_engine import #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix HAVE_TE detection across remaining files missing direct transformer_engine import #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f6b32f
Initial plan
Copilot Mar 10, 2026
5962b45
Fix HAVE_TE detection in layer_specs.py and radio_g.py to check trans…
Copilot Mar 10, 2026
d8aa8d8
Fix HAVE_TE detection in test_multi_token_prediction.py and test_upcy…
Copilot Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions examples/multimodal/layer_specs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,25 @@
from megatron.core.typed_torch import not_none

try:
import transformer_engine # pylint: disable=unused-import

HAVE_TE = True
from megatron.core.extensions.transformer_engine import (
TEColumnParallelLinear,
TEDotProductAttention,
TELayerNormColumnParallelLinear,
TENorm,
TERowParallelLinear,
)

HAVE_TE = True
except ImportError:
HAVE_TE = False
(
TEColumnParallelLinear,
TEDotProductAttention,
TELayerNormColumnParallelLinear,
TENorm,
TERowParallelLinear,
) = (None, None, None, None, None)
HAVE_TE = False

try:
import apex
Expand Down
7 changes: 4 additions & 3 deletions examples/multimodal/radio/radio_g.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,24 +18,25 @@
from megatron.core.typed_torch import not_none

try:
import transformer_engine # pylint: disable=unused-import

HAVE_TE = True
from megatron.core.extensions.transformer_engine import (
TEColumnParallelLinear,
TEDotProductAttention,
TELayerNormColumnParallelLinear,
TENorm,
TERowParallelLinear,
)

HAVE_TE = True
except ImportError:
HAVE_TE = False
(
TEColumnParallelLinear,
TEDotProductAttention,
TELayerNormColumnParallelLinear,
TENorm,
TERowParallelLinear,
) = (None, None, None, None, None)
HAVE_TE = False

try:
import apex
Expand Down
4 changes: 3 additions & 1 deletion tests/unit_tests/transformer/moe/test_upcycling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,13 @@
from tests.unit_tests.test_utilities import Utils

try:
from megatron.core.extensions.transformer_engine import TEColumnParallelGroupedLinear
import transformer_engine # pylint: disable=unused-import

HAVE_TE = True
from megatron.core.extensions.transformer_engine import TEColumnParallelGroupedLinear
except ImportError:
HAVE_TE = False
TEColumnParallelGroupedLinear = None

_SEED = 42

Expand Down
4 changes: 3 additions & 1 deletion tests/unit_tests/transformer/test_multi_token_prediction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,13 @@
from tests.unit_tests.test_utilities import Utils

try:
from megatron.core.extensions.transformer_engine import TEColumnParallelGroupedLinear
import transformer_engine # pylint: disable=unused-import

HAVE_TE = True
from megatron.core.extensions.transformer_engine import TEColumnParallelGroupedLinear
except ImportError:
HAVE_TE = False
TEColumnParallelGroupedLinear = None

_SEED = 42

Expand Down
Loading