Add support for diarization_type, speakers_count, remove_atmospherics #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillatrev
changed the title
kirillatrev
commented
Jun 17, 2024
src/rev_ai/apiclient.py
Outdated
| @@ -137,6 +139,10 @@ def submit_job_url( | |||
| segments_to_transcribe, speaker_names, | |||
| source_config, notification_config, | |||
| skip_postprocessing, | |||
| remove_atmospherics, | |||
There was a problem hiding this comment.
It appears that they were declared on the prototype but were not actually submitted....
kirillatrev
changed the title
kirillatrev
force-pushed
the
feature/AISDK-235
branch
from
4af1623 to
15085fa
Compare
|
@hrist0stoichev hrist0stoichev thank you for your contribution. |
eugenep-rev
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for diarization_type, speakers_count, remove_atmospherics
Follow up on
#104